Allon Mureinik has posted comments on this change.
Change subject: findbugs: String compression is not using equals method
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java
Line 95:
Line 96: @Override
Line 97: public boolean isTrue() {
Line 98: String quotaName = getModel().getQuotaName();
Line 99: return quotaName != null &&
!quotaName.equals("");
+1
Line 100: }
Line 101: }) {
Line 102: @Override
Line 103: public boolean isVisible() {
--
To view, visit http://gerrit.ovirt.org/14199
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I740261ed3383e147928505ea53edc19e2996ce69
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
