Allon Mureinik has posted comments on this change.
Change subject: engine: engine: add comment field to cluster
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File backend/manager/dbscripts/upgrade/03_03_0050_add_comment_vds_groups.sql
Line 1: select fn_db_add_column('vds_groups', 'comment', 'VARCHAR(4000) NOT
NULL default ''''');
Why not not null?
Why force the backend to handle empty strings instead of the proper database
way?
--
To view, visit http://gerrit.ovirt.org/14136
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib13317fb27fd9ad95959c22932334eb85025d7da
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
