Omer Frenkel has posted comments on this change.

Change subject: engine: watchdog - DB and logic changes
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File backend/manager/dbscripts/create_views.sql
Line 567: WHERE vm_static.entity_type = 'VM';
Line 568: 
Line 569: 
Line 570: 
Line 571: CREATE OR REPLACE VIEW vms_with_tags
i think it should be updated even if new fields are not searchable
Line 572: AS
Line 573: SELECT      vms.vm_name, vms.vm_mem_size_mb, vms.nice_level, 
vms.vmt_guid, vms.vm_os, vms.vm_description,
Line 574:             vms.vds_group_id, vms.vm_domain, vms.vm_creation_date, 
vms.auto_startup, vms.is_stateless, vms.is_smartcard_enabled, 
vms.is_delete_protected,
Line 575:             vms.dedicated_vm_for_vds, vms.fail_back, 
vms.default_boot_sequence, vms.vm_type,


--
To view, visit http://gerrit.ovirt.org/13057
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I813a6f97e23008d15446285998a4e9b50b456040
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to