Shahar Havivi has posted comments on this change.
Change subject: WIP core, restapi: cloud-init [1/4] - multiple files in VM
Payload
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java
Line 14: private static String SpecParamsPayload = "vmPayload";
Line 15: private static String SpecParamsFileType = "file";
Line 16:
Line 17: private VmDeviceType type;
Line 18: private Map<String, String> files; // file data is base64-encoded
You may want to considare using custom class for files if we want to add a new
field for the file (such as type, size)
Line 19:
Line 20: public VmPayload() {
Line 21: this.type = VmDeviceType.CDROM;
Line 22: this.files = new HashMap<String, String>();
--
To view, visit http://gerrit.ovirt.org/14348
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70934b8013459037f3d56573f80915bfa6b42bb4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
