Michael Pasternak has posted comments on this change. Change subject: findbugs: BackendAssignedPermissionsResource is Serializable but its superclass doesnt define an accessible void constructor ......................................................................
Patch Set 2: (1 inline comment) .................................................... Commit Message Line 3: AuthorDate: 2013-04-29 14:24:43 +0300 Line 4: Commit: Shahar Havivi <[email protected]> Line 5: CommitDate: 2013-04-29 14:28:03 +0300 Line 6: Line 7: findbugs: BackendAssignedPermissionsResource is Serializable but its superclass doesnt define an accessible void constructor what Comparator? and why it needs Serializable? Shahar, these are server side entities that should reside on server side only, and should not be Serializable (as they server side) & might contain sensitive info. also are you sure that findbugs complained about BackendAssignedPermissionsResource to begin with? if so, file bug for findbugs :-) Line 8: Line 9: Change-Id: Ic50008e0644465cd2d122ce6ddaf27de1f658ce8 -- To view, visit http://gerrit.ovirt.org/14315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic50008e0644465cd2d122ce6ddaf27de1f658ce8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
