Allon Mureinik has uploaded a new change for review. Change subject: core: Remove comparators' empty default ctors ......................................................................
core: Remove comparators' empty default ctors Removed empty implementation of the default constructor throughout the comparators package. These constructors have no added value, and just clatter up the code. Change-Id: Id8477d87cd992ceba047a4f07a75337b8ed7d30d Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/InterfaceComparerByMAC.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java 4 files changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/15/14415/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/InterfaceComparerByMAC.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/InterfaceComparerByMAC.java index 78f7d91..0f924e2 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/InterfaceComparerByMAC.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/InterfaceComparerByMAC.java @@ -12,7 +12,4 @@ public int compare(NetworkInterface<?> x, NetworkInterface<?> y) { return (x.getMacAddress().compareTo(y.getMacAddress())); } - - public InterfaceComparerByMAC() { - } } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java index 9ace701..9294c86 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java @@ -12,7 +12,4 @@ public int compare(VmTemplate x, VmTemplate y) { return (int) (x.getActualDiskSize() - y.getActualDiskSize()); } - - public VmTemplateComparerByDiskSize() { - } } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java index 6847818..3427ad9 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java @@ -12,7 +12,4 @@ public int compare(VM o1, VM o2) { return o1.getPriority() - o2.getPriority(); } - - public VmsComparer() { - } } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java index 5769b46..12148a3 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java @@ -12,7 +12,4 @@ public int compare(VM o1, VM o2) { return (int) (o1.getActualDiskWithSnapshotsSize() - o2.getActualDiskWithSnapshotsSize()); } - - public VmsComparerByDiskSize() { - } } -- To view, visit http://gerrit.ovirt.org/14415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id8477d87cd992ceba047a4f07a75337b8ed7d30d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
