Michael Pasternak has posted comments on this change.
Change subject: findbugs: switch case missing break
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
Line 161: model.setThresholds(new SchedulingPolicyThresholds());
Line 162: switch (entity.getselection_algorithm()) {
Line 163: case PowerSave:
Line 164:
model.getThresholds().setLow(entity.getlow_utilization());
Line 165: break;
breaking here is incorrect, to do it, you have to duplicate EvenlyDistribute
case content in to this one
Line 166: case EvenlyDistribute:
Line 167:
model.getThresholds().setHigh(entity.gethigh_utilization());
Line 168:
model.getThresholds().setDuration(entity.getcpu_over_commit_duration_minutes()
* 60);
Line 169: break;
--
To view, visit http://gerrit.ovirt.org/14380
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74a856015d74025399ff774d91e250b5cbd53184
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
