Allon Mureinik has uploaded a new change for review. Change subject: core: Allow editing a bootable disk ......................................................................
core: Allow editing a bootable disk Fixed a couple of bugs in getOtherVmDisks(Guid) to allow editing a bootable disk: 1. Once the list of disks is produced, it should be saved in the cache map 2. The break statement should be inside the if, not after it. Change-Id: I111de3ff5710d29d1301c0c47e12755d88e016b9 Bug-Url: https://bugzilla.redhat.com/959761 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/14439/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java index 070449f..b0f9db2 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java @@ -148,9 +148,10 @@ Disk evalDisk = iter.next(); if (evalDisk.getId().equals(oldDisk.getId())) { iter.remove(); + break; } - break; } + otherVmDisks.put(vmId, disks); } return disks; } -- To view, visit http://gerrit.ovirt.org/14439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I111de3ff5710d29d1301c0c47e12755d88e016b9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
