Allon Mureinik has posted comments on this change.
Change subject: core: live migrate - log error on failure
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
see inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java
Line 15:
Line 16: public class LiveMigrateDisksTaskHandler implements
SPMAsyncTaskHandler {
Line 17:
Line 18: private final TaskHandlerCommand<? extends
LiveMigrateVmDisksParameters> enclosingCommand;
Line 19: private final Log log = LogFactory.getLog(getClass());
use a static log please.
Line 20:
Line 21: public LiveMigrateDisksTaskHandler(TaskHandlerCommand<? extends
LiveMigrateVmDisksParameters> enclosingCommand) {
Line 22: this.enclosingCommand = enclosingCommand;
Line 23: }
--
To view, visit http://gerrit.ovirt.org/14440
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icae61b1c156e2bbb542a8790b310686028cc7a82
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
