Tal Nisan has uploaded a new change for review. Change subject: findbugs: Fix fingbugs errors in NfsStorageModel class ......................................................................
findbugs: Fix fingbugs errors in NfsStorageModel class Change-Id: Iddb575b6cbdfe69592cd2019f18be1a47e73c150 Signed-off-by: Tal Nisan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 2 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/61/14461/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java index 31b5a4b..3ca8407 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java @@ -1,9 +1,12 @@ package org.ovirt.engine.ui.uicommonweb.models.storage; +import java.util.ArrayList; +import java.util.List; + import org.ovirt.engine.core.common.businessentities.NfsVersion; import org.ovirt.engine.core.common.businessentities.StorageDomainType; -import org.ovirt.engine.core.common.businessentities.StorageType; import org.ovirt.engine.core.common.businessentities.StoragePool; +import org.ovirt.engine.core.common.businessentities.StorageType; import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.compat.Version; import org.ovirt.engine.ui.uicommonweb.UICommand; @@ -22,9 +25,6 @@ import org.ovirt.engine.ui.uicompat.EventDefinition; import org.ovirt.engine.ui.uicompat.IEventListener; -import java.util.ArrayList; -import java.util.List; - @SuppressWarnings("unused") public class NfsStorageModel extends Model implements IStorageModel { @@ -33,7 +33,7 @@ //timeo nfs option max value private final static short TIMEOUT_MAX = 6000; - public static EventDefinition PathChangedEventDefinition; + final static EventDefinition pathChangedEventDefinition; private Event pathChangedEvent; public Event getPathChangedEvent() { @@ -135,12 +135,12 @@ static { - PathChangedEventDefinition = new EventDefinition("PathChanged", NfsStorageModel.class); //$NON-NLS-1$ + pathChangedEventDefinition = new EventDefinition("PathChanged", NfsStorageModel.class); //$NON-NLS-1$ } public NfsStorageModel() { - setPathChangedEvent(new Event(PathChangedEventDefinition)); + setPathChangedEvent(new Event(pathChangedEventDefinition)); setUpdateCommand(new UICommand("Update", this)); //$NON-NLS-1$ diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java index 945d341..fbd711a 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java @@ -244,7 +244,7 @@ } } } - else if (ev.matchesDefinition(NfsStorageModel.PathChangedEventDefinition)) + else if (ev.matchesDefinition(NfsStorageModel.pathChangedEventDefinition)) { NfsStorageModel_PathChanged(sender, args); } -- To view, visit http://gerrit.ovirt.org/14461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iddb575b6cbdfe69592cd2019f18be1a47e73c150 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
