Tal Nisan has uploaded a new change for review. Change subject: findbugs: Fix fingbugs errors in CustomPropertyValidation class ......................................................................
findbugs: Fix fingbugs errors in CustomPropertyValidation class Change-Id: I330a0da5fd7211203e6399f2af068f1c7e2357e2 Signed-off-by: Tal Nisan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java 1 file changed, 10 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/66/14466/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java index 398d1d7..e3343c2 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java @@ -1,9 +1,9 @@ package org.ovirt.engine.ui.uicommonweb.validation; +import java.util.ArrayList; + import org.ovirt.engine.core.compat.StringHelper; import org.ovirt.engine.ui.uicompat.ConstantsManager; - -import java.util.ArrayList; @SuppressWarnings("unused") public class CustomPropertyValidation implements IValidation @@ -89,18 +89,21 @@ } if (!contains) { - String parameters = ""; //$NON-NLS-1$ - + StringBuilder parametersBuilder = new StringBuilder(); + boolean firstIteration = true; for (String keyValue : getCustomPropertiesKeysList()) { - parameters += keyValue.substring(0, keyValue.indexOf('=')) + ", "; //$NON-NLS-1$ + if (!firstIteration) { + parametersBuilder.append(", "); //$NON-NLS-1$ + } + parametersBuilder.append(keyValue.substring(0, keyValue.indexOf('='))); + firstIteration = false; } - parameters = parameters.substring(0, parameters.length() - 2); String reasonStr = ConstantsManager.getInstance() .getMessages() - .customPropertyOneOfTheParamsIsntSupported(parameters); + .customPropertyOneOfTheParamsIsntSupported(parametersBuilder.toString()); ArrayList<String> reason = new ArrayList<String>(); reason.add(reasonStr); -- To view, visit http://gerrit.ovirt.org/14466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I330a0da5fd7211203e6399f2af068f1c7e2357e2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
