Tal Nisan has uploaded a new change for review. Change subject: findbugs: Fix fingbugs error in StorageDiskListModel class ......................................................................
findbugs: Fix fingbugs error in StorageDiskListModel class Change-Id: Ib5c4504c7318bd90af4aa900090d6cbe19062a68 Signed-off-by: Tal Nisan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/54/14454/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java index 5a84764..31669b2 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java @@ -85,7 +85,7 @@ } } - public void Cancel() { + public void cancel() { setWindow(null); } @@ -130,7 +130,7 @@ return true; } - private void Remove() { + private void remove() { if (getWindow() != null) { return; } @@ -164,7 +164,7 @@ model.getCommands().add(cancelCommand); } - private void OnRemove() { + private void onRemove() { RemoveDiskModel model = (RemoveDiskModel) getWindow(); ArrayList<VdcActionParametersBase> paramerterList = new ArrayList<VdcActionParametersBase>(); @@ -182,7 +182,7 @@ public void executed(FrontendMultipleActionAsyncResult result) { StorageDiskListModel localModel = (StorageDiskListModel) result.getState(); localModel.StopProgress(); - Cancel(); + cancel(); } }, this); @@ -193,13 +193,13 @@ super.executeCommand(command); if (command == getRemoveCommand()) { - Remove(); + remove(); } else if (StringHelper.stringsEqual(command.getName(), "OnRemove")) { //$NON-NLS-1$ - OnRemove(); + onRemove(); } else if (StringHelper.stringsEqual(command.getName(), "Cancel")) { //$NON-NLS-1$ - Cancel(); + cancel(); } } -- To view, visit http://gerrit.ovirt.org/14454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5c4504c7318bd90af4aa900090d6cbe19062a68 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
