Tal Nisan has uploaded a new change for review. Change subject: findbugs: Fix fingbugs error in StorageModelBehavior class ......................................................................
findbugs: Fix fingbugs error in StorageModelBehavior class Change-Id: I31a978a4180b749a71a910fce989efafe4da79d9 Signed-off-by: Tal Nisan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java 4 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/14451/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java index 6bcbc76..7f8bfa3 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java @@ -15,15 +15,15 @@ public class ImportStorageModelBehavior extends StorageModelBehavior { @Override - public List<StoragePool> FilterDataCenter(List<StoragePool> source) + public List<StoragePool> filterDataCenter(List<StoragePool> source) { return Linq.toList(Linq.where(source, new Linq.DataCenterStatusPredicate(StoragePoolStatus.Up))); } @Override - public void UpdateItemsAvailability() + public void updateItemsAvailability() { - super.UpdateItemsAvailability(); + super.updateItemsAvailability(); StoragePool dataCenter = (StoragePool) getModel().getDataCenter().getSelectedItem(); @@ -80,6 +80,6 @@ model.setIsSelectable((dataCenter.getId().equals(StorageModel.UnassignedDataCenterId) || (item.getRole() == StorageDomainType.ISO && isNoStorageAttached) || (item.getRole() == StorageDomainType.ImportExport && isNoStorageAttached))); - behavior.OnStorageModelUpdated(item); + behavior.onStorageModelUpdated(item); } } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java index 7fd5e99..fdc7af8 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java @@ -13,9 +13,9 @@ public class NewEditStorageModelBehavior extends StorageModelBehavior { @Override - public void UpdateItemsAvailability() + public void updateItemsAvailability() { - super.UpdateItemsAvailability(); + super.updateItemsAvailability(); // Allow Data storage type corresponding to the selected data-center type + ISO and Export that are NFS only: for (IStorageModel item : Linq.<IStorageModel> cast(getModel().getItems())) @@ -83,6 +83,6 @@ model.setIsSelectable(isExistingStorage || (isNoneDataCenter && isData) || (!isNoneDataCenter && (canAttachData || canAttachExportOrIso))); - OnStorageModelUpdated(item); + onStorageModelUpdated(item); } } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java index 2b750e2..2e82e3b 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java @@ -442,7 +442,7 @@ StorageModelBehavior storageModelBehavior = (StorageModelBehavior) array[1]; List<StoragePool> dataCenters = (ArrayList<StoragePool>) returnValue; - dataCenters = storageModelBehavior.FilterDataCenter(dataCenters); + dataCenters = storageModelBehavior.filterDataCenter(dataCenters); StorageModel.addEmptyDataCenterToList(dataCenters); StoragePool oldSelectedItem = (StoragePool) storageModel.getDataCenter().getSelectedItem(); @@ -737,7 +737,7 @@ return; } - behavior.UpdateItemsAvailability(); + behavior.updateItemsAvailability(); } public boolean validate() { diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java index bf5d73c..8bee88d 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java @@ -41,12 +41,12 @@ privateHash = value; } - public List<StoragePool> FilterDataCenter(List<StoragePool> source) + public List<StoragePool> filterDataCenter(List<StoragePool> source) { return Linq.toList(Linq.where(source, new Linq.DataCenterNotStatusPredicate(StoragePoolStatus.NotOperational))); } - public void UpdateItemsAvailability() + public void updateItemsAvailability() { if (!Frontend.getQueryStartedEvent().getListeners().contains(this)) Frontend.getQueryStartedEvent().addListener(this); @@ -54,7 +54,7 @@ Frontend.getQueryCompleteEvent().addListener(this); } - public void FilterUnSelectableModels() + public void filterUnSelectableModels() { // Filter UnSelectable models from AvailableStorageItems list ArrayList<Object> filterredItems = new ArrayList<Object>(); @@ -70,7 +70,7 @@ getModel().getAvailableStorageItems().setItems(filterredItems); } - public void OnStorageModelUpdated(IStorageModel model) + public void onStorageModelUpdated(IStorageModel model) { // Update models list (the list is used for checking update completion) updatedStorageModels.add(model); @@ -83,7 +83,7 @@ getModel().getHost().setItems(new ArrayList<HostModel>()); getModel().getHost().setSelectedItem(null); - FilterUnSelectableModels(); + filterUnSelectableModels(); if (getModel().getSelectedItem() != null) { getModel().updateFormat(); -- To view, visit http://gerrit.ovirt.org/14451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I31a978a4180b749a71a910fce989efafe4da79d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
