Tal Nisan has uploaded a new change for review. Change subject: findbugs: Fix fingbugs errors in BookmarkListModel class ......................................................................
findbugs: Fix fingbugs errors in BookmarkListModel class Change-Id: I7315a2b9d7afbf6c8f91e283203ff668e69cf0d4 Signed-off-by: Tal Nisan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java 1 file changed, 18 insertions(+), 18 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/14480/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java index d746595..b2da974 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java @@ -125,7 +125,7 @@ setIsTimerDisabled(true); - UpdateActionAvailability(); + updateActionAvailability(); } public void executeBookmarksSearch() { @@ -200,7 +200,7 @@ model.getCommands().add(tempVar2); } - public void OnRemove() + public void onRemove() { Bookmark selectedBookmark = (Bookmark) getSelectedItem(); @@ -209,7 +209,7 @@ IFrontendActionAsyncCallback async = new IFrontendActionAsyncCallback() { @Override public void executed(FrontendActionAsyncResult result) { - PostOnSave(result.getReturnValue()); + postOnSave(result.getReturnValue()); } }; @@ -218,7 +218,7 @@ Frontend.RunAction(VdcActionType.RemoveBookmark, parameters, async); } - public void Edit() + public void edit() { org.ovirt.engine.core.common.businessentities.Bookmark bookmark = (org.ovirt.engine.core.common.businessentities.Bookmark) getSelectedItem(); @@ -246,7 +246,7 @@ model.getCommands().add(tempVar2); } - public void New() + public void newBookmark() { if (getWindow() != null) { @@ -270,7 +270,7 @@ model.getCommands().add(tempVar2); } - public void OnSave() + public void onSave() { BookmarkModel model = (BookmarkModel) getWindow(); @@ -301,26 +301,26 @@ public void executed(FrontendActionAsyncResult result) { BookmarkListModel localModel = (BookmarkListModel) result.getState(); - localModel.PostOnSave(result.getReturnValue()); + localModel.postOnSave(result.getReturnValue()); } }, this); } - public void PostOnSave(VdcReturnValueBase returnValue) + public void postOnSave(VdcReturnValueBase returnValue) { getWindow().stopProgress(); if (returnValue != null && returnValue.getSucceeded()) { - Cancel(); + cancel(); // Cancel() triggers a force refresh // getSearchCommand().Execute(); } } - public void Cancel() + public void cancel() { setWindow(null); } @@ -329,7 +329,7 @@ protected void onSelectedItemChanged() { super.onSelectedItemChanged(); - UpdateActionAvailability(); + updateActionAvailability(); if (getSelectedItem() != null && !getIsBookmarkInitiated()) { @@ -345,10 +345,10 @@ protected void selectedItemsChanged() { super.selectedItemsChanged(); - UpdateActionAvailability(); + updateActionAvailability(); } - private void UpdateActionAvailability() + private void updateActionAvailability() { getEditCommand().setIsExecutionAllowed(getSelectedItems() != null && getSelectedItems().size() == 1); getRemoveCommand().setIsExecutionAllowed(getSelectedItems() != null && getSelectedItems().size() > 0); @@ -361,11 +361,11 @@ if (command == getNewCommand()) { - New(); + newBookmark(); } else if (command == getEditCommand()) { - Edit(); + edit(); } else if (command == getRemoveCommand()) { @@ -374,16 +374,16 @@ else if (StringHelper.stringsEqual(command.getName(), "OnRemove")) //$NON-NLS-1$ { - OnRemove(); + onRemove(); } else if (StringHelper.stringsEqual(command.getName(), "OnSave")) //$NON-NLS-1$ { - OnSave(); + onSave(); } else if (StringHelper.stringsEqual(command.getName(), "Cancel")) //$NON-NLS-1$ { - Cancel(); + cancel(); } } -- To view, visit http://gerrit.ovirt.org/14480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7315a2b9d7afbf6c8f91e283203ff668e69cf0d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
