Tal Nisan has uploaded a new change for review. Change subject: findbugs: Fix fingbugs errors in ClusterGuideModel class ......................................................................
findbugs: Fix fingbugs errors in ClusterGuideModel class Change-Id: Ic13caac40ff1b4928f8b2c8b1c00df164214430a Signed-off-by: Tal Nisan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java 1 file changed, 41 insertions(+), 41 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/14481/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java index 6bad4a7..6271414 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java @@ -61,7 +61,7 @@ protected void onEntityChanged() { super.onEntityChanged(); - UpdateOptions(); + updateOptions(); } private ArrayList<VDS> hosts; @@ -70,7 +70,7 @@ private VDS localStorageHost; private StoragePool dataCenter; - private void UpdateOptionsNonLocalFSData() { + private void updateOptionsNonLocalFSData() { AsyncDataProvider.GetHostListByCluster(new AsyncQuery(this, new INewAsyncCallback() { @Override @@ -79,7 +79,7 @@ ArrayList<VDS> hosts = (ArrayList<VDS>) returnValue; ; clusterGuideModel.hosts = hosts; - clusterGuideModel.UpdateOptionsNonLocalFS(); + clusterGuideModel.updateOptionsNonLocalFS(); } }), getEntity().getname()); @@ -91,7 +91,7 @@ ArrayList<VDS> hosts = (ArrayList<VDS>) returnValue; ; clusterGuideModel.allHosts = hosts; - clusterGuideModel.UpdateOptionsNonLocalFS(); + clusterGuideModel.updateOptionsNonLocalFS(); } })); if (getEntity().supportsGlusterService()) { @@ -101,13 +101,13 @@ public void onSuccess(Object target, Object returnValue) { ClusterGuideModel clusterGuideModel = (ClusterGuideModel) target; isAnyHostUpInCluster = (Boolean) returnValue; - clusterGuideModel.UpdateOptionsNonLocalFS(); + clusterGuideModel.updateOptionsNonLocalFS(); } }), getEntity().getname()); } } - private void UpdateOptionsLocalFSData() { + private void updateOptionsLocalFSData() { AsyncDataProvider.GetLocalStorageHost(new AsyncQuery(this, new INewAsyncCallback() { @Override @@ -116,12 +116,12 @@ VDS localStorageHost = (VDS) returnValue; ; clusterGuideModel.localStorageHost = localStorageHost; - clusterGuideModel.UpdateOptionsLocalFS(); + clusterGuideModel.updateOptionsLocalFS(); } }), dataCenter.getname()); } - private void UpdateOptionsNonLocalFS() { + private void updateOptionsNonLocalFS() { if (hosts == null || allHosts == null || !isUpHostCheckCompleted()) { return; } @@ -188,7 +188,7 @@ stopProgress(); } - private void UpdateOptionsLocalFS() { + private void updateOptionsLocalFS() { UICommand addHostAction = new UICommand("AddHost", this); //$NON-NLS-1$ addHostAction.setTitle(ClusterAddAnotherHostAction); @@ -214,7 +214,7 @@ stopProgress(); } - private void UpdateOptions() + private void updateOptions() { getCompulsoryActions().clear(); getOptionalActions().clear(); @@ -233,11 +233,11 @@ if (model.dataCenter == null || model.dataCenter.getstorage_pool_type() != StorageType.LOCALFS) { - model.UpdateOptionsNonLocalFSData(); + model.updateOptionsNonLocalFSData(); } else { - model.UpdateOptionsLocalFSData(); + model.updateOptionsLocalFSData(); } } }), getEntity().getStoragePoolId().getValue()); @@ -258,7 +258,7 @@ return isAnyHostUpInCluster; } - private void ResetData() { + private void resetData() { hosts = null; allHosts = null; localStorageHost = null; @@ -266,7 +266,7 @@ isAnyHostUpInCluster = null; } - public void SelectHost() + public void selectHost() { final ArrayList<VDSGroup> clusters = new ArrayList<VDSGroup>(); clusters.add(getEntity()); @@ -304,7 +304,7 @@ }), getEntity().getStoragePoolId().getValue()); } - public void OnSelectHost() + public void onSelectHost() { MoveHost model = (MoveHost) getWindow(); @@ -365,15 +365,15 @@ } } clusterGuideModel.getWindow().stopProgress(); - clusterGuideModel.Cancel(); - clusterGuideModel.PostAction(); + clusterGuideModel.cancel(); + clusterGuideModel.postAction(); } }, this); } - public void AddHost() + public void addHost() { HostModel model = new HostModel(); setWindow(model); @@ -417,7 +417,7 @@ })); } - public void OnConfirmPMHost() + public void onConfirmPMHost() { HostModel model = (HostModel) getWindow(); @@ -446,13 +446,13 @@ } else { - OnAddHost(); + onAddHost(); } } - public void OnAddHost() + public void onAddHost() { - CancelConfirm(); + cancelConfirm(); HostModel model = (HostModel) getWindow(); @@ -507,13 +507,13 @@ public void executed(FrontendActionAsyncResult result) { ClusterGuideModel localModel = (ClusterGuideModel) result.getState(); - localModel.PostOnAddHost(result.getReturnValue()); + localModel.postOnAddHost(result.getReturnValue()); } }, this); } - public void PostOnAddHost(VdcReturnValueBase returnValue) + public void postOnAddHost(VdcReturnValueBase returnValue) { HostModel model = (HostModel) getWindow(); @@ -521,29 +521,29 @@ if (returnValue != null && returnValue.getSucceeded()) { - Cancel(); - PostAction(); + cancel(); + postAction(); } } - private void PostAction() + private void postAction() { - ResetData(); - UpdateOptions(); + resetData(); + updateOptions(); } - public void Cancel() + public void cancel() { - ResetData(); + resetData(); setWindow(null); } - public void CancelConfirm() + public void cancelConfirm() { setConfirmWindow(null); } - public void CancelConfirmWithFocus() + public void cancelConfirmWithFocus() { setConfirmWindow(null); @@ -558,35 +558,35 @@ if (StringHelper.stringsEqual(command.getName(), "AddHost")) //$NON-NLS-1$ { - AddHost(); + addHost(); } if (StringHelper.stringsEqual(command.getName(), "OnConfirmPMHost")) //$NON-NLS-1$ { - OnConfirmPMHost(); + onConfirmPMHost(); } if (StringHelper.stringsEqual(command.getName(), "OnAddHost")) //$NON-NLS-1$ { - OnAddHost(); + onAddHost(); } if (StringHelper.stringsEqual(command.getName(), "SelectHost")) //$NON-NLS-1$ { - SelectHost(); + selectHost(); } if (StringHelper.stringsEqual(command.getName(), "OnSelectHost")) //$NON-NLS-1$ { - OnSelectHost(); + onSelectHost(); } if (StringHelper.stringsEqual(command.getName(), "Cancel")) //$NON-NLS-1$ { - Cancel(); + cancel(); } if (StringHelper.stringsEqual(command.getName(), "CancelConfirm")) //$NON-NLS-1$ { - CancelConfirm(); + cancelConfirm(); } if (StringHelper.stringsEqual(command.getName(), "CancelConfirmWithFocus")) //$NON-NLS-1$ { - CancelConfirmWithFocus(); + cancelConfirmWithFocus(); } } } -- To view, visit http://gerrit.ovirt.org/14481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic13caac40ff1b4928f8b2c8b1c00df164214430a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
