Tal Nisan has uploaded a new change for review. Change subject: findbugs: Fix fingbugs errors in ClusterListModel class ......................................................................
findbugs: Fix fingbugs errors in ClusterListModel class Change-Id: I494e0a984540378fa90321da9a503f6296bec198 Signed-off-by: Tal Nisan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java 1 file changed, 45 insertions(+), 45 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/14482/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java index 4eac6d2..d34d4df 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java @@ -200,13 +200,13 @@ setGuideCommand(new UICommand("Guide", this)); //$NON-NLS-1$ setAddMultipleHostsCommand(new UICommand("AddHosts", this)); //$NON-NLS-1$ - UpdateActionAvailability(); + updateActionAvailability(); getSearchNextPageCommand().setIsAvailable(true); getSearchPreviousPageCommand().setIsAvailable(true); } - public void Guide() + public void guide() { ClusterGuideModel model = new ClusterGuideModel(); setWindow(model); @@ -291,7 +291,7 @@ setItems(getAsyncResult().getData()); } - public void New() + public void newCluster() { if (getWindow() != null) { @@ -346,7 +346,7 @@ AsyncDataProvider.GetDataCenterList(_asyncQuery); } - public void Edit() + public void edit() { final VDSGroup cluster = (VDSGroup) getSelectedItem(); @@ -465,7 +465,7 @@ model.getCommands().add(tempVar2); } - public void OnRemove() + public void onRemove() { ConfirmationModel model = (ConfirmationModel) getWindow(); @@ -489,13 +489,13 @@ ConfirmationModel localModel = (ConfirmationModel) result.getState(); localModel.stopProgress(); - Cancel(); + cancel(); } }, model); } - public void OnSave() + public void onSave() { ClusterModel model = (ClusterModel) getWindow(); @@ -509,15 +509,15 @@ } else if (model.getIsNew()) { - OnPreSaveInternal(model); + onPreSaveInternal(model); } else { - OnSaveConfirmCV(model); + onSaveConfirmCV(model); } } - private void OnSaveConfirmCV(ClusterModel model) + private void onSaveConfirmCV(ClusterModel model) { if (!((Version) model.getVersion().getSelectedItem()).equals(((VDSGroup) getSelectedItem()).getcompatibility_version())) { ConfirmationModel confirmModel = new ConfirmationModel(); @@ -539,16 +539,16 @@ tempVar2.setIsCancel(true); getConfirmWindow().getCommands().add(tempVar2); } else { - OnSaveConfirmCpuThreads(); + onSaveConfirmCpuThreads(); } } - private void OnSaveConfirmCpuThreads() + private void onSaveConfirmCpuThreads() { ClusterModel model = (ClusterModel) getWindow(); // cancel confirm window if there is one - CancelConfirmation(); + cancelConfirmation(); // CPU thread support is being turned off either explicitly or via version change if (!((Boolean) model.getVersionSupportsCpuThreads().getEntity() && (Boolean) model.getCountThreadsAsCores().getEntity()) @@ -572,11 +572,11 @@ tempVar2.setIsCancel(true); getConfirmWindow().getCommands().add(tempVar2); } else { - OnSaveInternal(); + onSaveInternal(); } } - public void OnPreSaveInternal(ClusterModel model) + public void onPreSaveInternal(ClusterModel model) { if ((Boolean) model.getIsImportGlusterConfiguration().getEntity()) { @@ -584,11 +584,11 @@ } else { - OnSaveInternal(); + onSaveInternal(); } } - public void OnSaveInternal() + public void onSaveInternal() { ClusterModel model = (ClusterModel) getWindow(); @@ -598,12 +598,12 @@ } // cancel confirm window if there is - CancelConfirmation(); + cancelConfirmation(); - OnSaveInternalWithModel(model); + onSaveInternalWithModel(model); } - private void OnSaveInternalWithModel(final ClusterModel model) { + private void onSaveInternalWithModel(final ClusterModel model) { VDSGroup cluster = model.getIsNew() ? new VDSGroup() : (VDSGroup) Cloner.clone(getSelectedItem()); Version version = (Version) model.getVersion().getSelectedItem(); @@ -645,7 +645,7 @@ localModel.postOnSaveInternalWithImport(result.getReturnValue()); } else { - localModel.PostOnSaveInternal(result.getReturnValue()); + localModel.postOnSaveInternal(result.getReturnValue()); } } }, @@ -762,11 +762,11 @@ } else { - OnSaveInternalWithModel(hostsModel.getClusterModel()); + onSaveInternalWithModel(hostsModel.getClusterModel()); } } - public void PostOnSaveInternal(VdcReturnValueBase returnValue) + public void postOnSaveInternal(VdcReturnValueBase returnValue) { ClusterModel model = (ClusterModel) getWindow(); @@ -774,12 +774,12 @@ if (returnValue != null && returnValue.getSucceeded()) { - Cancel(); + cancel(); if (model.getIsNew()) { setGuideContext(returnValue.getActionReturnValue()); - UpdateActionAvailability(); + updateActionAvailability(); getGuideCommand().Execute(); } } @@ -840,23 +840,23 @@ } if (isAllCanDoPassed) { - Cancel(); + cancel(); } } }, null); } - public void Cancel() + public void cancel() { - CancelConfirmation(); + cancelConfirmation(); setGuideContext(null); setWindow(null); - UpdateActionAvailability(); + updateActionAvailability(); } - public void CancelConfirmation() + public void cancelConfirmation() { setConfirmWindow(null); } @@ -865,14 +865,14 @@ protected void onSelectedItemChanged() { super.onSelectedItemChanged(); - UpdateActionAvailability(); + updateActionAvailability(); } @Override protected void selectedItemsChanged() { super.selectedItemsChanged(); - UpdateActionAvailability(); + updateActionAvailability(); } @Override @@ -890,7 +890,7 @@ } } - private void UpdateActionAvailability() + private void updateActionAvailability() { getEditCommand().setIsExecutionAllowed(getSelectedItem() != null && getSelectedItems() != null && getSelectedItems().size() == 1); @@ -926,11 +926,11 @@ if (command == getNewCommand()) { - New(); + newCluster(); } else if (command == getEditCommand()) { - Edit(); + edit(); } else if (command == getRemoveCommand()) { @@ -938,31 +938,31 @@ } else if (command == getGuideCommand()) { - Guide(); + guide(); } else if (StringHelper.stringsEqual(command.getName(), "OnSave")) //$NON-NLS-1$ { - OnSave(); + onSave(); } else if (StringHelper.stringsEqual(command.getName(), "Cancel")) //$NON-NLS-1$ { - Cancel(); + cancel(); } else if (StringHelper.stringsEqual(command.getName(), "OnRemove")) //$NON-NLS-1$ { - OnRemove(); + onRemove(); } else if (StringHelper.stringsEqual(command.getName(), "OnSaveConfirmCpuThreads")) //$NON-NLS-1$ { - OnSaveConfirmCpuThreads(); + onSaveConfirmCpuThreads(); } else if (StringHelper.stringsEqual(command.getName(), "OnSaveInternal")) //$NON-NLS-1$ { - OnSaveInternal(); + onSaveInternal(); } else if (StringHelper.stringsEqual(command.getName(), "CancelConfirmation")) //$NON-NLS-1$ { - CancelConfirmation(); + cancelConfirmation(); } else if (StringHelper.stringsEqual(command.getName(), "OnSaveHosts")) //$NON-NLS-1$ { @@ -984,13 +984,13 @@ if (systemTreeSelectedItem != value) { systemTreeSelectedItem = value; - OnSystemTreeSelectedItemChanged(); + onSystemTreeSelectedItemChanged(); } } - private void OnSystemTreeSelectedItemChanged() + private void onSystemTreeSelectedItemChanged() { - UpdateActionAvailability(); + updateActionAvailability(); } @Override -- To view, visit http://gerrit.ovirt.org/14482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I494e0a984540378fa90321da9a503f6296bec198 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
