Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: cleanup Frontend ......................................................................
Patch Set 1: (2 inline comments) Daniel, so if I understand you right, then runAction and runMultipleActions should not have been marked deprecated, but simply modified to call the async version with the appropriate parameters? .................................................... Commit Message Line 12: - Replaced calls to deprecated methods which returned null with Line 13: just null. Line 14: Line 15: Change-Id: I36b970b9b53ff568bef04c41859a1dcc958c98f8 Line 16: Bug-Url: https://bugzilla.redhat.com/?????? Yeah that shouldn't be in there, was having some issue with the commit message and started over, must have missed removing this. .................................................... File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java Line 489 Line 490 Line 491 Line 492 Line 493 Well the signature was marked deprecated, that is why I removed it, but yes in general that would be the way to do it. -- To view, visit http://gerrit.ovirt.org/14410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36b970b9b53ff568bef04c41859a1dcc958c98f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
