Hello Mark Huth,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/14526
to review the following change.
Change subject: packaging: make validateFQDN case insensitive
......................................................................
packaging: make validateFQDN case insensitive
If the specified FQDN to rhevm-setup is a different case to that
returned by the DNS PTR record, then validateFQDN reports that the
reverse-resolved name doesn't match the supplied name and fails the
validation and hence rhevm-setup fails.
This patch makes validateFQDN case insensitive so it doesn't matter if
the supplied FQDN differs in case to that retured by the DNS PTR record,
because DNS itself is case insensitive.
Change-Id: I7619971956c1eba8b6d3f2a345b8fc85a778384e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=928165
Signed-off-by: Mark Huth <[email protected]>
---
M packaging/fedora/setup/engine_validators.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/14526/1
diff --git a/packaging/fedora/setup/engine_validators.py
b/packaging/fedora/setup/engine_validators.py
index 0b8f5e2..571657b 100644
--- a/packaging/fedora/setup/engine_validators.py
+++ b/packaging/fedora/setup/engine_validators.py
@@ -343,7 +343,7 @@
reResolvedAddress = None
if len(addressSet) > 0:
reResolvedAddress = addressSet.pop()
- if reResolvedAddress == param:
+ if reResolvedAddress.lower() == param.lower():
counter += 1
else:
logging.warn("%s did not reverse-resolve into
%s"%(address,param))
--
To view, visit http://gerrit.ovirt.org/14526
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7619971956c1eba8b6d3f2a345b8fc85a778384e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Mark Huth <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
