Sandro Bonazzola has uploaded a new change for review. Change subject: packaging: fixing fqdn validation ......................................................................
packaging: fixing fqdn validation if _getPatternFromNslookup returns an empty set, the validation will have caused a traceback. Change-Id: I4bf1385fbb1770c990c4b31c59d829ce91e4ed00 Signed-off-by: Sandro Bonazzola <[email protected]> --- M packaging/fedora/setup/engine_validators.py 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/14527/1 diff --git a/packaging/fedora/setup/engine_validators.py b/packaging/fedora/setup/engine_validators.py index 571657b..ed7b483 100644 --- a/packaging/fedora/setup/engine_validators.py +++ b/packaging/fedora/setup/engine_validators.py @@ -341,11 +341,13 @@ for address in resolvedAddresses: addressSet = _getPatternFromNslookup(address, pattern) reResolvedAddress = None + revResolved = False if len(addressSet) > 0: reResolvedAddress = addressSet.pop() - if reResolvedAddress.lower() == param.lower(): - counter += 1 - else: + if reResolvedAddress.lower() == param.lower(): + counter += 1 + revResolved = True + if not revResolved: logging.warn("%s did not reverse-resolve into %s"%(address,param)) if counter < 1: logging.error("The following addresses: %s did not reverse resolve into %s"%(prettyString, param)) -- To view, visit http://gerrit.ovirt.org/14527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4bf1385fbb1770c990c4b31c59d829ce91e4ed00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
