Laszlo Hornyak has uploaded a new change for review. Change subject: engine: cleanup RedirectServlet (3/N) ......................................................................
engine: cleanup RedirectServlet (3/N) - use commons-lang StringUtil to check returned value Change-Id: Ib51ed8abbbbca374a75ad94c79ef4aad31fac9f7 Signed-off-by: Laszlo Hornyak <[email protected]> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/14552/1 diff --git a/backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java b/backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java index 239eb2b..ff73b8f 100644 --- a/backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java +++ b/backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java @@ -8,6 +8,7 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; +import org.apache.commons.lang.StringUtils; import org.ovirt.engine.core.bll.interfaces.BackendInternal; import org.ovirt.engine.core.common.config.ConfigCommon; import org.ovirt.engine.core.common.queries.GetConfigurationValueParameters; @@ -49,7 +50,7 @@ v = backend.runInternalQuery(VdcQueryType.GetConfigurationValue, params); if (v != null) { - retVal = (v.getSucceeded() && v.getReturnValue() != null && !((String)v.getReturnValue()).trim().equals("")) + retVal = (v.getSucceeded() && StringUtils.isNotEmpty((String) v.getReturnValue())) ? v.getReturnValue().toString() : null; } else { log.error("Redirect Servlet: Got NULL from backend.RunQuery!"); -- To view, visit http://gerrit.ovirt.org/14552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib51ed8abbbbca374a75ad94c79ef4aad31fac9f7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
