Laszlo Hornyak has uploaded a new change for review. Change subject: engine: cleanup RedirectServlet (6/N) ......................................................................
engine: cleanup RedirectServlet (6/N) - removed misleading log message (may be copy-paste from health status servlet) Change-Id: I9006cd0337b490199c0518837f21ef7caeb55fbf Signed-off-by: Laszlo Hornyak <[email protected]> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/55/14555/1 diff --git a/backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java b/backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java index 0009722..0b65619 100644 --- a/backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java +++ b/backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java @@ -39,8 +39,6 @@ // ***************************************************************************** // private String getConfigValue(ConfigurationValues conf) { - String retVal = null; - try { BackendInternal backend = (BackendInternal) EjbUtils.findBean(BeanType.BACKEND, BeanProxyType.LOCAL); @@ -49,7 +47,7 @@ VdcQueryReturnValue v = backend.runInternalQuery(VdcQueryType.GetConfigurationValue, params); if (v != null) { - retVal = (v.getSucceeded() && StringUtils.isNotEmpty((String) v.getReturnValue())) + return (v.getSucceeded() && StringUtils.isNotEmpty((String) v.getReturnValue())) ? v.getReturnValue().toString() : null; } else { log.error("Redirect Servlet: Got NULL from backend.RunQuery!"); @@ -58,7 +56,7 @@ log.error("Redirect Servlet: Caught exception while trying to run query: ", t); } - return retVal; + return null; } protected void addAlert(PrintWriter out, String message) { @@ -101,7 +99,6 @@ } finally { out.close(); } - log.debug("Health Status servlet: close"); } protected void doPost(HttpServletRequest request, HttpServletResponse response) -- To view, visit http://gerrit.ovirt.org/14555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9006cd0337b490199c0518837f21ef7caeb55fbf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
