Yair Zaslavsky has posted comments on this change.
Change subject: core: reduce compensation scope from hibernate command
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java
Line 44: .toString()));
Line 45:
Line 46: if (vdsReturnValue != null && vdsReturnValue.getCreationInfo()
!= null) {
Line 47: getReturnValue().getInternalTaskIdList().add(
Line 48:
createTaskSuspendTransaction(vdsReturnValue.getCreationInfo(),
Why not use createTask? doesnt it call createTaskSuspendTransaction?
Line 49: VdcActionType.RemoveSnapshot,
Line 50:
ExecutionMessageDirector.resolveStepMessage(StepEnum.MERGE_SNAPSHOTS,
getJobMessageProperties()),
Line 51: VdcObjectType.Storage,
Line 52: storageDomainId));
--
To view, visit http://gerrit.ovirt.org/14510
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec46798fc6ea01ef6b0b4701e1af5ba616edf910
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
