Gilad Chaplik has uploaded a new change for review. Change subject: core: empty role shouldn't be valid ......................................................................
core: empty role shouldn't be valid Apparently we add Login action group to all roles (behind the scene). Changed server validation to decline roles that contains only Login action group since it's not visible to the user (ui). Change-Id: Ic6826e5a9765c4280ba73c31fd93137a228e3c52 Signed-off-by: Gilad Chaplik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/86/14586/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java index 50f0f06..ae3f674 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java @@ -37,7 +37,10 @@ @Override protected boolean canDoAction() { - if (getParameters().getActionGroups().isEmpty()) { + if (getParameters().getActionGroups().isEmpty() + || (getParameters().getActionGroups().size() == 1 && getParameters().getActionGroups() + .get(0) + .equals(ActionGroup.LOGIN))) { addCanDoActionMessage(VdcBllMessages.ACTION_LIST_CANNOT_BE_EMPTY); return false; } -- To view, visit http://gerrit.ovirt.org/14586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6826e5a9765c4280ba73c31fd93137a228e3c52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
