Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs errors in ListModel class
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(4 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java
Line 17: @SuppressWarnings("unused")
Line 18: public class ListModel extends EntityModel
Line 19: {
Line 20:
Line 21: public final static EventDefinition
selectedItemChangedEventDefinition;
should actually be public static final
Line 22: private Event privateSelectedItemChangedEvent;
Line 23:
Line 24: public Event getSelectedItemChangedEvent()
Line 25: {
Line 30: {
Line 31: privateSelectedItemChangedEvent = value;
Line 32: }
Line 33:
Line 34: public final static EventDefinition
selectedItemsChangedEventDefinition;
should actually be public static final
Line 35: private Event privateSelectedItemsChangedEvent;
Line 36:
Line 37: public Event getSelectedItemsChangedEvent()
Line 38: {
Line 43: {
Line 44: privateSelectedItemsChangedEvent = value;
Line 45: }
Line 46:
Line 47: public final static EventDefinition itemsChangedEventDefinition;
should actually be public static final
Line 48: private Event privateItemsChangedEvent;
Line 49:
Line 50: public Event getItemsChangedEvent()
Line 51: {
Line 147: static
Line 148: {
Line 149: selectedItemChangedEventDefinition = new
EventDefinition("SelectedItemChanged", ListModel.class); //$NON-NLS-1$
Line 150: selectedItemsChangedEventDefinition = new
EventDefinition("SelectedItemsChanged", ListModel.class); //$NON-NLS-1$
Line 151: itemsChangedEventDefinition = new
EventDefinition("ItemsChanged", ListModel.class); //$NON-NLS-1$
I'd inline these with the member's definitions while you're at it.
Line 152: }
Line 153:
Line 154: public ListModel()
Line 155: {
--
To view, visit http://gerrit.ovirt.org/14472
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2395f9657f2c602e5450a03bc57fc6ec1870f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
