Tal Nisan has posted comments on this change.
Change subject: findbugs: Remove dead local storage in uicommonweb project
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java
Line 512: return;
Line 513: }
Line 514:
Line 515: // Check name unicitate.
Line 516: // String name = (String) model.getName().getEntity();
Because it's a remnant of a code that was commented out, without this if
someone ever uncomments the code there will be a part missing
Line 517: // if (!DataProvider.IsRoleNameUnique(name) &&
name.compareToIgnoreCase(role.getname()) != 0)
Line 518: // {
Line 519: // model.getName().setIsValid(false);
Line 520: // model.getName().getInvalidityReasons().add("Name must be
unique.");
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskStorageListModel.java
Line 76: UpdateActionAvailability();
Line 77: }
Line 78:
Line 79: private void UpdateActionAvailability()
Line 80: {
I figured it was left to be filled later with content since we have it in most
list models
Can be removed though
Line 81: }
Line 82:
Line 83: @Override
Line 84: protected String getListName() {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskTemplateListModel.java
Line 81: UpdateActionAvailability();
Line 82: }
Line 83:
Line 84: private void UpdateActionAvailability()
Line 85: {
Same
Line 86: }
Line 87:
Line 88: @Override
Line 89: protected String getListName() {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/PoolItemBehavior.java
Line 76: if (!result.getReturnValue().getSucceeded()) {
Line 77: return;
Line 78: }
Line 79:
Line 80: VdcReturnValueBase returnValueBase =
result.getReturnValue();
DLS is dead local store, it doesn't mean removing of dead code it's removing
local variables which are not used within the local scope and thus are redundant
Line 81: }
Line 82: }, this);
Line 83: }
Line 84:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 615: ArrayList<StorageDomain> activeDiskStorageDomains
=
Line 616: Linq.getStorageDomainsByIds(storageIds,
activeStorageDomains);
Line 617:
Line 618: // Set target storage domains
Line 619: ArrayList<StorageDomain>
availableDiskStorageDomains =
Not the scope of this patch
Line 620: provisioning ? activeStorageDomains :
activeDiskStorageDomains;
Line 621: Linq.sort(availableDiskStorageDomains, new
Linq.StorageDomainByNameComparer());
Line 622:
diskModel.getStorageDomain().setItems(availableDiskStorageDomains);
Line 623:
--
To view, visit http://gerrit.ovirt.org/14475
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1afe4e408b6a4f1b652a710369250c9ddb3d2ca7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
