Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs errors in DataCenterListModel &
DataCenterModel classes
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
Line 531: }
Line 532:
Line 533: public void activate()
Line 534: {
Line 535: }
Do we really need this method?
Line 536:
Line 537: public void onRemove()
Line 538: {
Line 539: ConfirmationModel model = (ConfirmationModel) getWindow();
--
To view, visit http://gerrit.ovirt.org/14484
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9748ab5cd3151971f272c7e45c068fdf219f93d1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
