Omer Frenkel has posted comments on this change.
Change subject: core: [cleanup] introduce GetAllFromExportDomainQuery class
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetAllFromExportDomainQuery.java
Line 48: protected VDSReturnValue executeVerb(StorageDomainStatic storage) {
Line 49: try {
Line 50: GetVmsInfoVDSCommandParameters tempVar = new
GetVmsInfoVDSCommandParameters(
Line 51: getParameters().getStoragePoolId());
Line 52:
tempVar.setStorageDomainId(getParameters().getStorageDomainId());
why use domain id from parameters and not from storage object from method
parameter?
Line 53: tempVar.setVmIdList(getParameters().getIds());
Line 54: return Backend.getInstance().getResourceManager()
Line 55: .RunVdsCommand(VDSCommandType.GetVmsInfo, tempVar);
Line 56: } catch (RuntimeException e) {
Line 61: }
Line 62: }
Line 63:
Line 64: protected boolean isValidExportDomain() {
Line 65: StorageDomain domain =
DbFacade.getInstance().getStorageDomainDao().getForStoragePool(
i think it would be better to get the domain from the db only once and cache it
Line 66: getParameters().getStorageDomainId(),
Line 67: getParameters().getStoragePoolId());
Line 68: return domain != null && domain.getStorageDomainType() ==
StorageDomainType.ImportExport;
Line 69: }
--
To view, visit http://gerrit.ovirt.org/14593
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2544cb879898ef90d64feb8a16dcfb8cf103b409
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
