Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: Change remove message ......................................................................
Patch Set 1: (1 inline comment) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java Line 84 Line 85 Line 86 Line 87 Line 88 Alex - I believe that "messages.removeConfirmationPopupMessage" should be removed from the code entirely. I am not sure if there are any usages for it other than this file, but if there are - they should be replaced with the new "constants.removeConfirmationPopupMessage", and "removeConfirmationPopupMessage" should be removed from Messages (it is important to remove it in order to make sure that it won't be used anymore, as any usage can create a translation problem wherever this message is used). What do you think? -- To view, visit http://gerrit.ovirt.org/14621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia934e33d1a975e0235e1a1ffae0c8a4a7af66f10 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
