Alon Bar-Lev has posted comments on this change.
Change subject: packaging: remove bash usage from tools
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File packaging/bin/engine-config.sh
Line 46: }
Line 47:
Line 48: # TODO:
Line 49: # why do we need CONF_FILE here?
Line 50: # we do not use any vairable
please reply.
Line 51: CONF_FILE="${ENGINE_ETC}/engine-config/engine-config.conf"
Line 52: ARGS=""
Line 53:
Line 54: while [ -n "$1" ]; do
....................................................
File packaging/bin/engine-manage-domains.sh
Line 48: }
Line 49:
Line 50: # TODO:
Line 51: # why do we need CONF_FILE here?
Line 52: # we do not use any vairable
please reply.
Line 53: CONF_DIR="${ENGINE_ETC}/engine-manage-domains"
Line 54: CONF_FILE="${CONF_DIR}/engine-manage-domains.conf"
Line 55: ARGS=""
Line 56:
Line 78: . "${CONF_FILE}"
Line 79:
Line 80: # TODO:
Line 81: # what is the benefit of creating this here
Line 82: # and not at java code?
please reply.
Line 83: PROPERTIES_FILE="$(mktemp)" || die "Temporary properties file cannot
be created"
Line 84: cleanup() {
Line 85: rm -fr "${PROPERTIES_FILE}"
Line 86: }
--
To view, visit http://gerrit.ovirt.org/14661
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40064044a6da2b1088ee5d40eff874b9f8db66c3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
