Allon Mureinik has posted comments on this change.
Change subject: core: removed limitation of get topSizeVms query
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsByStorageDomainQuery.java
Line 16: import org.ovirt.engine.core.common.queries.VdcQueryType;
Line 17: import org.ovirt.engine.core.compat.Guid;
Line 18:
Line 19: public class GetVmsByStorageDomainQuery<P extends
StorageDomainQueryParametersBase>
Line 20: extends QueriesCommandBase<P> {
Good point :-)
Line 21: public GetVmsByStorageDomainQuery(P parameters) {
Line 22: super(parameters);
Line 23: }
Line 24:
Line 32: // get all disks and snapshots
Line 33: VdcQueryReturnValue queryReturnValue =
getAllDisksByStorageDomain(domainId);
Line 34: if (queryReturnValue.getSucceeded()) {
Line 35: disksOfDomain = (List<DiskImage>)
queryReturnValue.getReturnValue();
Line 36: }
Probably log it, and fail this query too - otherwise, you'd be (1) reporting
incomplete data and (2) hiding the failure
Line 37:
Line 38: Map<String, VM> vmNameToVMMap = new HashMap();
Line 39:
Line 40: for (VM vm : vms) {
--
To view, visit http://gerrit.ovirt.org/14558
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44f746a9321282fa99c7a11de92e720e3e0c610
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
