Gilad Chaplik has posted comments on this change. Change subject: findbugs: Fix fingbugs errors in RemoveStorageModel class ......................................................................
Patch Set 1: No score Tal, your patches are separated per class, this causes an unneeded overhead in reviewing and coding and may cause regressions; these patches should be logically separated according to 'findbugs' type; Please strongly consider changing it. -- To view, visit http://gerrit.ovirt.org/14460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80d831a80bd15c7f700d8298a264bea5e877b4f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
