Oved Ourfali has posted comments on this change.
Change subject: engine: Added provider CRUD operations
......................................................................
Patch Set 16: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/AddProviderCommand.java
Line 31: @Override
Line 32: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 33: return Collections.singletonList(new
PermissionSubject(Guid.SYSTEM,
Line 34: VdcObjectType.System,
Line 35: ActionGroup.CREATE_STORAGE_POOL));
same comment here.
Line 36: }
Line 37:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java
Line 29: @Override
Line 30: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 31: return Collections.singletonList(new
PermissionSubject(Guid.SYSTEM,
Line 32: VdcObjectType.System,
Line 33: ActionGroup.CREATE_STORAGE_POOL));
same comment here.
Line 34: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/UpdateProviderCommand.java
Line 29: @Override
Line 30: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 31: return Collections.singletonList(new
PermissionSubject(Guid.SYSTEM,
Line 32: VdcObjectType.System,
Line 33: ActionGroup.CREATE_STORAGE_POOL));
Why do we require CREATE_STORAGE_POOL? not saying it is wrong, but just making
sure that you thought about what permissions one needs in order to
create/manipulate providers.
Line 34: }
--
To view, visit http://gerrit.ovirt.org/10848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa74c2adb7d755f5b916629cec415d56461bbb13
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
