Lior Vernia has uploaded a new change for review. Change subject: webadmin: Revamped Provider/General subtab ......................................................................
webadmin: Revamped Provider/General subtab Added more fields to the subtab. Change-Id: I45351c96a0f56cf5726e5d87a2d046c0c2b77ca5 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderGeneralView.java 2 files changed, 41 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/14697/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderGeneralModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderGeneralModel.java index 3bed43d..1b6978b 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderGeneralModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderGeneralModel.java @@ -6,9 +6,16 @@ import org.ovirt.engine.ui.uicompat.ConstantsManager; import org.ovirt.engine.ui.uicompat.PropertyChangedEventArgs; -public class ProviderGeneralModel extends EntityModel -{ +@SuppressWarnings("deprecation") +public class ProviderGeneralModel extends EntityModel { + + private static final String PROPERTY_NAME = "Name"; //$NON-NLS-1$ + private static final String PROPERTY_DESCRIPTION = "Description"; //$NON-NLS-1$ + private static final String PROPERTY_URL = "Url"; //$NON-NLS-1$ + private String name; + private String description; + private String url; public ProviderGeneralModel() { setTitle(ConstantsManager.getInstance().getConstants().generalTitle()); @@ -19,8 +26,7 @@ protected void OnEntityChanged() { super.OnEntityChanged(); - if (super.getEntity() != null) - { + if (getEntity() != null) { UpdateProperties(); } } @@ -36,7 +42,8 @@ Provider provider = (Provider) getEntity(); setName(provider.getName()); - + setDescription(provider.getDescription()); + setUrl(provider.getUrl()); } public String getName() { @@ -44,10 +51,32 @@ } public void setName(String value) { - if (!StringHelper.stringsEqual(name, value)) - { + if (!StringHelper.stringsEqual(name, value)) { name = value; - OnPropertyChanged(new PropertyChangedEventArgs("Name")); //$NON-NLS-1$ + OnPropertyChanged(new PropertyChangedEventArgs(PROPERTY_NAME)); } } + + public String getDescription() { + return description; + } + + public void setDescription(String value) { + if (!StringHelper.stringsEqual(description, value)) { + description = value; + OnPropertyChanged(new PropertyChangedEventArgs(PROPERTY_DESCRIPTION)); + } + } + + public String getUrl() { + return url; + } + + public void setUrl(String value) { + if (!StringHelper.stringsEqual(url, value)) { + url = value; + OnPropertyChanged(new PropertyChangedEventArgs(PROPERTY_URL)); + } + } + } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderGeneralView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderGeneralView.java index 9575279..4411303 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderGeneralView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderGeneralView.java @@ -35,6 +35,8 @@ private final ApplicationConstants constants = ClientGinjectorProvider.instance().getApplicationConstants(); TextBoxLabel name = new TextBoxLabel(); + TextBoxLabel description = new TextBoxLabel(); + TextBoxLabel url = new TextBoxLabel(); @UiField(provided = true) GeneralFormPanel formPanel; @@ -56,6 +58,8 @@ formBuilder.setColumnsWidth("300px", "300px"); //$NON-NLS-1$ //$NON-NLS-2$ formBuilder.addFormItem(new FormItem(constants.nameProvider(), name, 0, 0)); + formBuilder.addFormItem(new FormItem(constants.descriptionProvider(), description, 1, 0)); + formBuilder.addFormItem(new FormItem(constants.urlProvider(), url, 2, 0)); } @Override -- To view, visit http://gerrit.ovirt.org/14697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45351c96a0f56cf5726e5d87a2d046c0c2b77ca5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
