Alon Bar-Lev has posted comments on this change.
Change subject: packaging - fix otopi implementation version locking handling
......................................................................
Patch Set 1: (1 inline comment)
I was kind of hopping we can use some generic signature on lines so we can
reuse mechanism...
Add to uninstall a list of files with signature to be processed.
....................................................
File packaging/setup/plugins/ovirt-engine-setup/distro-rpm/versionlock.py
Line 62: condition=lambda self: self._enabled,
Line 63: )
Line 64: def _configversionlock(self):
Line 65: #Can't assume we're the owner of the locking list.
Line 66: content = ''
content = osetupcons.Const.RPM_LOCK_LIST
if ...
...
content += f.read().splitlines()
please always use f as trivial file... try to use lists for lines.
question... if we alreayd have our packages, won't we have duplicate?
Line 67: if os.path.exists(
Line 68: osetupcons.FileLocations.OVIRT_ENGINE_YUM_VERSIONLOCK
Line 69: ):
Line 70: with open(
--
To view, visit http://gerrit.ovirt.org/14700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1b9142088cfa7def37f6d1ad3d2a4204aebe8ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
