Sandro Bonazzola has uploaded a new change for review.

Change subject: packaging: fixed interaction in AIO for engine-setup-2
......................................................................

packaging: fixed interaction in AIO for engine-setup-2

in all-in-one storage plugin, fixed the interaction with
the user at customization stage.

Change-Id: I0e7f8c17aa997748895c51e57132e28a504b1cc7
Signed-off-by: Sandro Bonazzola <[email protected]>
---
M packaging/setup/plugins/ovirt-engine-setup/all-in-one/storage.py
1 file changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/14733/1

diff --git a/packaging/setup/plugins/ovirt-engine-setup/all-in-one/storage.py 
b/packaging/setup/plugins/ovirt-engine-setup/all-in-one/storage.py
index d882dc8..6f18424 100644
--- a/packaging/setup/plugins/ovirt-engine-setup/all-in-one/storage.py
+++ b/packaging/setup/plugins/ovirt-engine-setup/all-in-one/storage.py
@@ -84,7 +84,7 @@
         """
         interactive = self.environment[
             osetupcons.AIOEnv.STORAGE_DOMAIN_DIR
-        ]
+        ] is None
 
         validDomain = False
         while not validDomain:
@@ -96,16 +96,16 @@
                     default_dir += '-%s' % (
                         datetime.datetime.utcnow().strftime('%Y%m%d%H%M%S')
                     )
-
-                self.environment[
-                    osetupcons.AIOEnv.STORAGE_DOMAIN_DIR
-                ] = self.dialog.queryString(
-                    name='OVESETUP_AIO_STORAGE_DOMAIN_DIR',
-                    note=_('Local storage domain path [@DEFAULT@]: '),
-                    prompt=True,
-                    caseSensitive=True,
-                    default=default_dir,
-                )
+                if interactive:
+                    self.environment[
+                        osetupcons.AIOEnv.STORAGE_DOMAIN_DIR
+                    ] = self.dialog.queryString(
+                        name='OVESETUP_AIO_STORAGE_DOMAIN_DIR',
+                        note=_('Local storage domain path [@DEFAULT@]: '),
+                        prompt=True,
+                        caseSensitive=True,
+                        default=default_dir,
+                    )
 
                 self._validateDomain(
                     path=self.environment[


--
To view, visit http://gerrit.ovirt.org/14733
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e7f8c17aa997748895c51e57132e28a504b1cc7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to