Vojtech Szocs has posted comments on this change.
Change subject: userportal: Console buttons clickable area fix
......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve
Initially, I thought we can avoid DIV element eventTarget detection via
"data-class" attribute, but it seems GWT CellTable always renders HTML table
cells like this:
<td class="...">
<div style="outline:none">
<actual Cell HTML goes here>
</div>
</td>
The wrapper DIV is due to CellTable.Template.div(SafeHtml) method, which cannot
be avoided, so in the end, we still need some attribute-based detection of
actual Cell DIV element.
--
To view, visit http://gerrit.ovirt.org/14535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8a0da49e86bc01c73e7a2a7226da773d659a6fc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
