Alon Bar-Lev has posted comments on this change.
Change subject: oVirt Node Upgrade: Support N configurations
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeInfo.java
Line 15: this.prefixNode = Config.<String>
GetValue(ConfigValues.OvirtIsoPrefix);
Line 16: this.minimumVersion = Config.<String>
GetValue(ConfigValues.OvirtInitialSupportedIsoVersion);
Line 17: this.ISOsPath = Config.resolveOVirtISOsRepositoryPath();
Line 18: this.uploadPath = Config.<String>
GetValue(ConfigValues.oVirtUploadPath);
Line 19: this.upgradeScriptName = Config.<String>
GetValue(ConfigValues.oVirtUpgradeScriptName);
The whole point is to convert the database format to data structure in one
place. Just reading the config into variables does not reduce complexity, and
hide the database structure from users.
If you read database values here, I suggest to have:
public static OVirtNodeInfo[] getInfo() {
}
This will return an array as I suggested before, so logic within the users of
the class will be reduced.
Line 20: this.infoDelimiter = ":";
Line 21: }
Line 22:
Line 23: public String getUploadPath() {
--
To view, visit http://gerrit.ovirt.org/14756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
