Alon Bar-Lev has posted comments on this change.

Change subject: packaging: allow interactive PKI cleanup with engine-cleanup-2
......................................................................


Patch Set 2: (2 inline comments)

Looks OK, but waiting for the dependency of uninstall to stabilize.

....................................................
Commit Message
Line 3: AuthorDate: 2013-05-14 15:34:29 +0200
Line 4: Commit:     Sandro Bonazzola <[email protected]>
Line 5: CommitDate: 2013-05-15 16:50:32 +0200
Line 6: 
Line 7: packaging: allow interactive PKI cleanup with engine-cleanup-2
Please use subcomponent name in commits...

 packaging: setup: xxx

Also, push with topic: packaging/setup

This will allow us to find changes quicker.
Line 8: 
Line 9: - cleanup PKI configuration and keys only if requested
Line 10: - backup PKI configuration and keys it cleanup requested
Line 11: 


....................................................
File packaging/setup/plugins/ovirt-engine-remove/config/ca.py
Line 133: 
Line 134: 
Line 135: 
Line 136: 
Line 137: 
extra spaces


--
To view, visit http://gerrit.ovirt.org/14732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6efe201ed5a9dee7f681ffd61c8f988d24a33a7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to