Shahar Havivi has uploaded a new change for review. Change subject: findbugs: assigned value never used ......................................................................
findbugs: assigned value never used Assigning Guid.Empty to vmToAttach, but it never used. We override this value in the next statement. findbugs code: DLS: Dead store to local variable that shadows field Change-Id: I42dd82224a31840157cfcbd499e91f607830bc06 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/75/14775/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java index c2e4ee0..cdbe10a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java @@ -165,7 +165,7 @@ initUser(); boolean isPrestartedVm = false; - Guid vmToAttach = Guid.Empty; + Guid vmToAttach; synchronized (_lockObject) { vmToAttach = getPrestartedVmToAttach(getParameters().getVmPoolId()); if (!Guid.Empty.equals(vmToAttach)) { -- To view, visit http://gerrit.ovirt.org/14775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I42dd82224a31840157cfcbd499e91f607830bc06 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
