Daniel Erez has posted comments on this change.
Change subject: core: Fix unauthorized move-disk
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 721: getActionType().getActionGroup()));
Line 722: if (getVmTemplate() != null &&
!getVmTemplate().getDiskList().isEmpty()) {
Line 723: for (DiskImage disk :
getParameters().getDiskInfoDestinationMap().values()) {
Line 724: if (disk.getStorageIds() != null &&
!disk.getStorageIds().isEmpty()) {
Line 725: permissionList.add(new
PermissionSubject(GuidUtils.getGuidValue(disk.getStorageIds().get(0)),
There's only one target SD.
Line 726: VdcObjectType.Storage,
ActionGroup.CREATE_DISK));
Line 727: }
Line 728: }
Line 729: }
--
To view, visit http://gerrit.ovirt.org/14769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32713cbcf3206ab449ddca9b0ebd382bf77a7582
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
