Yair Zaslavsky has posted comments on this change.
Change subject: engine: Add validations to provider commands
......................................................................
Patch Set 10: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java
Line 26: }
Line 27:
Line 28: private Provider getDeletedProvider() {
Line 29: if (deletedProvider == null) {
Line 30: deletedProvider =
getDbFacade().getProviderDao().get(getParameters().getProvider().getId());
why not encapsulate with getProviderDao() and not
getDbFacade().getProviderDao() ?
Line 31: }
Line 32:
Line 33: return deletedProvider;
Line 34: }
--
To view, visit http://gerrit.ovirt.org/12362
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09d2b74718f8d04e5f28fd622658ff11636ee74e
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
