Mike Kolesnik has posted comments on this change.
Change subject: engine: Command for testing provider connectivity
......................................................................
Patch Set 10: (2 inline comments)
Thanks for the review, please see my comments inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxyFactory.java
Line 16: * The provider to get the factory for.
Line 17: * @return The factory for creating a proxy.
Line 18: */
Line 19: public static ProviderProxyFactory getFactory(Provider provider) {
Line 20: return null;
Since this is only the infrastructural part, there is no implementation.
Future patches will add their own factories and implementation for this method.
Line 21: }
Line 22:
Line 23: /**
Line 24: * Create a proxy for the provider.<br>
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/TestProviderConnectivityCommand.java
Line 37:
Line 38: @Override
Line 39: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 40: return Collections.singletonList(new
PermissionSubject(Guid.SYSTEM,
Line 41: VdcObjectType.System,
Yes but since this is only a first patch to get things working, there is no
specific providers permissions.
The providers permissions model will be added in a following patch.
Line 42: ActionGroup.CREATE_STORAGE_POOL));
Line 43: }
Line 44:
--
To view, visit http://gerrit.ovirt.org/12366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19e04f45f72c76f99c283ba39dfa31e3a7624cbf
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
