Shahar Havivi has uploaded a new change for review. Change subject: findbugs: Random object should be used more then once for better random ......................................................................
findbugs: Random object should be used more then once for better random findbugs code: DMI: Random object created and used only once Change-Id: I6e8c345507542829b6b31a7be5f482ec00f71397 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParametersTest.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdUsersSearchParametersTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/CustomMapSqlParameterSourceTest.java 3 files changed, 24 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/14777/1 diff --git a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParametersTest.java b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParametersTest.java index cc48d3b..598a9d5 100644 --- a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParametersTest.java +++ b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParametersTest.java @@ -5,11 +5,19 @@ import java.util.Random; +import org.junit.Before; import org.junit.Test; import org.ovirt.engine.core.common.interfaces.SearchType; /** A test case for the {@link AdGroupsSearchParameters} class */ public class AdGroupsSearchParametersTest { + + private Random random; + + @Before + public void setUp() { + this.random = new Random(); + } @Test public void testOneArgConstructor() { @@ -23,7 +31,7 @@ @Test public void testTwoArgConstructor() { String pattern = "pattern"; - boolean caseSensitive = new Random().nextBoolean(); + boolean caseSensitive = this.random.nextBoolean(); AdGroupsSearchParameters params = new AdGroupsSearchParameters(pattern, caseSensitive); assertTrue("Wrong pattern", params.getSearchPattern().endsWith(pattern)); diff --git a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdUsersSearchParametersTest.java b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdUsersSearchParametersTest.java index 2919d77..a24aff3 100644 --- a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdUsersSearchParametersTest.java +++ b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdUsersSearchParametersTest.java @@ -5,11 +5,19 @@ import java.util.Random; +import org.junit.Before; import org.junit.Test; import org.ovirt.engine.core.common.interfaces.SearchType; /** A test case for the {@link AdUsersSearchParameters} class */ public class AdUsersSearchParametersTest { + + private Random random; + + @Before + public void setUp() { + this.random = new Random(); + } @Test public void testOneArgConstructor() { @@ -23,7 +31,7 @@ @Test public void testTwoArgConstructor() { String pattern = "pattern"; - boolean caseSensitive = new Random().nextBoolean(); + boolean caseSensitive = this.random.nextBoolean(); AdUsersSearchParameters params = new AdUsersSearchParameters(pattern, caseSensitive); assertTrue("Wrong pattern", params.getSearchPattern().endsWith(pattern)); diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/CustomMapSqlParameterSourceTest.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/CustomMapSqlParameterSourceTest.java index 6709ab8..30be4ed 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/CustomMapSqlParameterSourceTest.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/CustomMapSqlParameterSourceTest.java @@ -17,6 +17,8 @@ /** A test case for the {@link CustomMapSqlParameterSource} */ public class CustomMapSqlParameterSourceTest { + private Random random; + /** The {@link CustomMapSqlParameterSourceTest} to be tested */ private CustomMapSqlParameterSource paramSource; @@ -46,11 +48,13 @@ paramSource = new CustomMapSqlParameterSource(dialectMock); paramName = RandomStringUtils.randomAlphabetic(10); + + this.random = new Random(); } @Test public void testAddValuePrimitive() { - int paramValue = new Random().nextInt(); + int paramValue = this.random.nextInt(); paramSource.addValue(paramName, paramValue); assertEquals("wrong value returned from parameter source", @@ -86,7 +90,7 @@ @Test public void testAddValueVersion() { - Version verision = new Version(new Random().nextInt(), new Random().nextInt()); + Version verision = new Version(this.random.nextInt(), new Random().nextInt()); paramSource.addValue(paramName, verision); assertEquals("wrong value returned from parameter source", -- To view, visit http://gerrit.ovirt.org/14777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6e8c345507542829b6b31a7be5f482ec00f71397 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
