Mike Kolesnik has posted comments on this change.
Change subject: engine: Added provider table & DAO
......................................................................
Patch Set 20: (2 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/03_03_0150_add_providers_table.sql
Line 2: CREATE TABLE providers
Line 3: (
Line 4: id UUID CONSTRAINT providers_pk PRIMARY KEY,
Line 5: name VARCHAR(128) NOT NULL,
Line 6: description VARCHAR(4000),
I'm not quite sure what you mean..
There is URL field, is this what you mean?
Line 7: url VARCHAR(512) NOT NULL,
Line 8: provider_type VARCHAR(32) NOT NULL,
Line 9: auth_required BOOLEAN NOT NULL,
Line 10: auth_username VARCHAR(64),
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoDbFacadeImpl.java
Line 56: entity.setUrl(rs.getString("url"));
Line 57:
entity.setType(ProviderType.valueOf(rs.getString("provider_type")));
Line 58:
entity.setRequiringAuthentication(rs.getBoolean("auth_required"));
Line 59: entity.setUsername(rs.getString("auth_username"));
Line 60:
entity.setPassword(DbFacadeUtils.decryptPassword(rs.getString("auth_password")));
Currently I think this will be good enough.
If we will see a performance issue here, we can consider a more complex design.
Line 61: return entity;
Line 62: }
Line 63: }
--
To view, visit http://gerrit.ovirt.org/10785
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa461cb6721b866c0a6f6531365c8af4d46eb1bb
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
