Shahar Havivi has uploaded a new change for review. Change subject: findbugs: use valueOf instead of number constructor ......................................................................
findbugs: use valueOf instead of number constructor findbugs code: Bx: Method invokes inefficient Number constructor; use static valueOf instead Change-Id: If77d88f1862d2e75871b28695f7d8631eb30cc91 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ObjectUtilsTest.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/14782/1 diff --git a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ObjectUtilsTest.java b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ObjectUtilsTest.java index cfff2b7..6191f02 100644 --- a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ObjectUtilsTest.java +++ b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ObjectUtilsTest.java @@ -10,9 +10,9 @@ @Test public void testObjectsEqual() { - Integer ten = new Integer(10); - assertFalse(ObjectUtils.objectsEqual(ten, new Integer(20))); - assertTrue(ObjectUtils.objectsEqual(ten, new Integer(10))); + Integer ten = Integer.valueOf(10); + assertFalse(ObjectUtils.objectsEqual(ten, Integer.valueOf(20))); + assertTrue(ObjectUtils.objectsEqual(ten, Integer.valueOf(10))); assertTrue(ObjectUtils.objectsEqual(null, null)); assertFalse(ObjectUtils.objectsEqual(ten, null)); assertFalse(ObjectUtils.objectsEqual(null, ten)); -- To view, visit http://gerrit.ovirt.org/14782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If77d88f1862d2e75871b28695f7d8631eb30cc91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
