Allon Mureinik has uploaded a new change for review. Change subject: core: Remove Unused query parameters ......................................................................
core: Remove Unused query parameters Removed unused query parameter classes. Change-Id: Ic032e6cf878f364f760a36779d8aba969ef57231 Signed-off-by: Allon Mureinik <[email protected]> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAdGroupsAttachedToVmPoolParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllUsersInVdcRoleParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmSnapshotsParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetByUserIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDbUserByVmPoolIdParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsAttachedToAdGroupParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ImportCandidateInfoBase.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ImportCandidateSourceEnum.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/TemplateCandidateInfo.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VmCandidateInfo.java 10 files changed, 0 insertions(+), 236 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/87/14787/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAdGroupsAttachedToVmPoolParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAdGroupsAttachedToVmPoolParameters.java deleted file mode 100644 index 024f644..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAdGroupsAttachedToVmPoolParameters.java +++ /dev/null @@ -1,18 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -public class GetAdGroupsAttachedToVmPoolParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = 6796451423817563295L; - - public GetAdGroupsAttachedToVmPoolParameters(int id) { - _id = id; - } - - private int _id; - - public int getId() { - return _id; - } - - public GetAdGroupsAttachedToVmPoolParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllUsersInVdcRoleParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllUsersInVdcRoleParameters.java deleted file mode 100644 index 2daf3ad..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllUsersInVdcRoleParameters.java +++ /dev/null @@ -1,20 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -import org.ovirt.engine.core.common.businessentities.*; - -public class GetAllUsersInVdcRoleParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = 4075283289991368556L; - - public GetAllUsersInVdcRoleParameters(VdcRole id) { - _id = id; - } - - private VdcRole _id = VdcRole.forValue(0); - - public VdcRole getId() { - return _id; - } - - public GetAllUsersInVdcRoleParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmSnapshotsParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmSnapshotsParameters.java deleted file mode 100644 index 7e22d10..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmSnapshotsParameters.java +++ /dev/null @@ -1,20 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -import org.ovirt.engine.core.compat.*; - -public class GetAllVmSnapshotsParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = -788238010985994689L; - - public GetAllVmSnapshotsParameters(Guid id) { - _id = id; - } - - private Guid _id = new Guid(); - - public Guid getId() { - return _id; - } - - public GetAllVmSnapshotsParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetByUserIdParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetByUserIdParameters.java deleted file mode 100644 index d3e4e79..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetByUserIdParameters.java +++ /dev/null @@ -1,28 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -import org.ovirt.engine.core.compat.Guid; - -/** - * class for all getById queries by user ids TODO re-factor commands that duplicates this functionality. extend this - * class if more than id is needed - */ -public class GetByUserIdParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = 1092832045219008933L; - private Guid userId; - - public GetByUserIdParameters() { - } - - public GetByUserIdParameters(Guid userId) { - this.userId = userId; - } - - public void setUserId(Guid userId) { - this.userId = userId; - } - - public Guid getUserId() { - return userId; - } - -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDbUserByVmPoolIdParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDbUserByVmPoolIdParameters.java deleted file mode 100644 index c0663dd..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDbUserByVmPoolIdParameters.java +++ /dev/null @@ -1,18 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -public class GetDbUserByVmPoolIdParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = 789118868522923324L; - - public GetDbUserByVmPoolIdParameters(int id) { - _id = id; - } - - private int _id; - - public int getId() { - return _id; - } - - public GetDbUserByVmPoolIdParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsAttachedToAdGroupParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsAttachedToAdGroupParameters.java deleted file mode 100644 index 1e5f9af..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsAttachedToAdGroupParameters.java +++ /dev/null @@ -1,20 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -import org.ovirt.engine.core.compat.*; - -public class GetVmsAttachedToAdGroupParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = 6577838883414480497L; - - public GetVmsAttachedToAdGroupParameters(Guid id) { - _id = id; - } - - private Guid _id = new Guid(); - - public Guid getId() { - return _id; - } - - public GetVmsAttachedToAdGroupParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ImportCandidateInfoBase.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ImportCandidateInfoBase.java deleted file mode 100644 index d2e1e75..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ImportCandidateInfoBase.java +++ /dev/null @@ -1,38 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -import org.ovirt.engine.core.common.businessentities.*; -import java.util.List; -import java.util.Map; - -public abstract class ImportCandidateInfoBase { - private ImportCandidateSourceEnum privateCandidateSource = ImportCandidateSourceEnum.forValue(0); - - public ImportCandidateSourceEnum getCandidateSource() { - return privateCandidateSource; - } - - public void setCandidateSource(ImportCandidateSourceEnum value) { - privateCandidateSource = value; - } - - private java.util.HashMap<String, List<DiskImage>> privateImagesData; - - public Map<String, List<DiskImage>> getImagesData() { - return privateImagesData; - } - - public void setImagesData(java.util.HashMap<String, List<DiskImage>> value) { - privateImagesData = value; - } - - public ImportCandidateInfoBase(ImportCandidateSourceEnum candidateSource, - java.util.HashMap<String, List<DiskImage>> imagesData) { - setImagesData(imagesData); - setCandidateSource(candidateSource); - } - - public abstract String getCandidateDisplayName(); - - public ImportCandidateInfoBase() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ImportCandidateSourceEnum.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ImportCandidateSourceEnum.java deleted file mode 100644 index 9769849..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ImportCandidateSourceEnum.java +++ /dev/null @@ -1,14 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -public enum ImportCandidateSourceEnum { - KVM, - VMWARE; - - public int getValue() { - return this.ordinal(); - } - - public static ImportCandidateSourceEnum forValue(int value) { - return values()[value]; - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/TemplateCandidateInfo.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/TemplateCandidateInfo.java deleted file mode 100644 index d68b3e9..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/TemplateCandidateInfo.java +++ /dev/null @@ -1,30 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -import org.ovirt.engine.core.common.businessentities.*; -import java.util.List; - -public class TemplateCandidateInfo extends ImportCandidateInfoBase { - private VmTemplate privateVmTemplateData; - - public VmTemplate getVmTemplateData() { - return privateVmTemplateData; - } - - public void setVmTemplateData(VmTemplate value) { - privateVmTemplateData = value; - } - - public TemplateCandidateInfo(VmTemplate vmTemplateData, ImportCandidateSourceEnum candidateSource, - java.util.HashMap<String, List<DiskImage>> imagesData) { - super(candidateSource, imagesData); - setVmTemplateData(vmTemplateData); - } - - @Override - public String getCandidateDisplayName() { - return getVmTemplateData().getName(); - } - - public TemplateCandidateInfo() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VmCandidateInfo.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VmCandidateInfo.java deleted file mode 100644 index 407cb95..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VmCandidateInfo.java +++ /dev/null @@ -1,30 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -import org.ovirt.engine.core.common.businessentities.*; -import java.util.List; - -public class VmCandidateInfo extends ImportCandidateInfoBase { - private VmStatic privateVmData; - - public VmStatic getVmData() { - return privateVmData; - } - - public void setVmData(VmStatic value) { - privateVmData = value; - } - - public VmCandidateInfo(VmStatic vmData, ImportCandidateSourceEnum candidateSource, - java.util.HashMap<String, List<DiskImage>> imagesData) { - super(candidateSource, imagesData); - setVmData(vmData); - } - - @Override - public String getCandidateDisplayName() { - return getVmData().getName(); - } - - public VmCandidateInfo() { - } -} -- To view, visit http://gerrit.ovirt.org/14787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic032e6cf878f364f760a36779d8aba969ef57231 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
