Allon Mureinik has uploaded a new change for review. Change subject: core: Remove ValidateStorageDomainVDSCommand ......................................................................
core: Remove ValidateStorageDomainVDSCommand HSMGetTaskInfoCommand is not used anywhere in the codebase, and thus should be removed. Change-Id: Id9df37d1d0ef54b86d0c43072d365197bb1f0167 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ValidateStorageDomainVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 5 files changed, 0 insertions(+), 33 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/99/14799/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java index 5d1770f..374ed7f 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java @@ -69,7 +69,6 @@ HsmGetIsoList("org.ovirt.engine.core.vdsbroker.vdsbroker"), GetFloppyList("org.ovirt.engine.core.vdsbroker.irsbroker"), CreateStorageDomain("org.ovirt.engine.core.vdsbroker.vdsbroker"), - ValidateStorageDomain("org.ovirt.engine.core.vdsbroker.vdsbroker"), ActivateStorageDomain("org.ovirt.engine.core.vdsbroker.irsbroker"), DeactivateStorageDomain("org.ovirt.engine.core.vdsbroker.irsbroker"), DetachStorageDomain("org.ovirt.engine.core.vdsbroker.irsbroker"), diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java index 9baa9a8..0bb2ee5 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java @@ -93,8 +93,6 @@ ServerConnectionListReturnForXmlRpc getStorageConnectionsList(String spUUID); - StatusOnlyReturnForXmlRpc validateStorageDomain(String sdUUID); - StatusOnlyReturnForXmlRpc createStorageDomain(int domainType, String sdUUID, String domainName, String arg, int storageType, String storageFormatType); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ValidateStorageDomainVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ValidateStorageDomainVDSCommand.java deleted file mode 100644 index 7c8610d..0000000 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ValidateStorageDomainVDSCommand.java +++ /dev/null @@ -1,16 +0,0 @@ -package org.ovirt.engine.core.vdsbroker.vdsbroker; - -import org.ovirt.engine.core.common.vdscommands.*; - -public class ValidateStorageDomainVDSCommand<P extends ValidateStorageDomainVDSCommandParameters> - extends VdsBrokerCommand<P> { - public ValidateStorageDomainVDSCommand(P parameters) { - super(parameters); - } - - @Override - protected void ExecuteVdsBrokerCommand() { - status = getBroker().validateStorageDomain(getParameters().getStorageDomainId().toString()); - ProceedProxyReturnValue(); - } -} diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java index aea65e0..809abec 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java @@ -78,8 +78,6 @@ public Map<String, Object> getStorageConnectionsList(String spUUID); - public Map<String, Object> validateStorageDomain(String sdUUID); - public Map<String, Object> createStorageDomain(int domainType, String sdUUID, String domainName, String arg, int storageType, String storageFormatType); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java index dc94e77..4adaa7f 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java @@ -438,18 +438,6 @@ } @Override - public StatusOnlyReturnForXmlRpc validateStorageDomain(String sdUUID) { - try { - Map<String, Object> xmlRpcReturnValue = vdsServer.validateStorageDomain(sdUUID); - StatusOnlyReturnForXmlRpc wrapper = new StatusOnlyReturnForXmlRpc(xmlRpcReturnValue); - return wrapper; - } catch (UndeclaredThrowableException ute) { - throw new XmlRpcRunTimeException(ute); - } - - } - - @Override public StatusOnlyReturnForXmlRpc createStorageDomain(int domainType, String sdUUID, String domainName, String arg, int storageType, String storageFormatType) { try { -- To view, visit http://gerrit.ovirt.org/14799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id9df37d1d0ef54b86d0c43072d365197bb1f0167 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
