Allon Mureinik has uploaded a new change for review. Change subject: engine: Forbid star imports ......................................................................
engine: Forbid star imports By the project's conventions (which are enforced by code review) * imports are not allowed. This patch adds a checkstyle validation to ensure these errors are caught at build time instead of review time. Change-Id: I62cd280184ad2baf8ad8298b32b0a1f61d4bc0b2 Signed-off-by: Allon Mureinik <[email protected]> --- M build-tools-root/checkstyles/src/main/resources/checkstyle.xml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/14809/1 diff --git a/build-tools-root/checkstyles/src/main/resources/checkstyle.xml b/build-tools-root/checkstyles/src/main/resources/checkstyle.xml index e74928b..a9db716 100644 --- a/build-tools-root/checkstyles/src/main/resources/checkstyle.xml +++ b/build-tools-root/checkstyles/src/main/resources/checkstyle.xml @@ -16,6 +16,7 @@ <property name="cacheFile" value="${checkstyle.cache.file}"/> <module name="RedundantImport"/> <module name="UnusedImports"/> + <module name="AvoidStarImport"/> <module name="checks.NlsCheck"> <property name="run" value="${runNlsCheck}" default="false"/> </module> -- To view, visit http://gerrit.ovirt.org/14809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I62cd280184ad2baf8ad8298b32b0a1f61d4bc0b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
