Allon Mureinik has uploaded a new change for review. Change subject: core: Fix RunOnce from a CD-ROM ......................................................................
core: Fix RunOnce from a CD-ROM Change-Id I2c10427764fa58faee54afaa89c4e5e62f5bad82 introduced a regression that did not allow booting from an ISO, as it misused the VM's storage pool ID as an ISO domain's ID. This patch recreates the original behaviour by finding the active ISO domain in the pool, and passing that on to validation. Change-Id: I8298cdbfd9ba3b629cd72c0cb6267cdb5469ab61 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/18/14818/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java index 8303cb9..1aa7477 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java @@ -135,12 +135,15 @@ @SuppressWarnings("unchecked") public ValidationResult validateIsoPath(boolean isAutoStartup, - Guid storageDomainId, + Guid storagePoolId, String diskPath, String floppyPath) { if (isAutoStartup) { return ValidationResult.VALID; } + + Guid storageDomainId = getIsoDomainListSyncronizer().findActiveISODomain(storagePoolId); + if (!StringUtils.isEmpty(diskPath)) { if (storageDomainId == null) { return new ValidationResult(VdcBllMessages.VM_CANNOT_RUN_FROM_CD_WITHOUT_ACTIVE_STORAGE_DOMAIN_ISO); -- To view, visit http://gerrit.ovirt.org/14818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8298cdbfd9ba3b629cd72c0cb6267cdb5469ab61 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
