Oved Ourfali has posted comments on this change. Change subject: findbugs: returning local variable that is not written ......................................................................
Patch Set 2: (1 inline comment) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiCommandButtonDefinition.java Line 43: private final List<HandlerRegistration> handlerRegistrations = new ArrayList<HandlerRegistration>(); Line 44: Line 45: private final SafeHtml title; Line 46: Line 47: private String customToolTip; I'd initialize it here, but that's a matter of style. Also, don't you need the //$NON-NLS-1$ comment? Otherwise the build usually fails. Line 48: Line 49: // Indicates whether the given feature is implemented in WebAdmin Line 50: private final boolean implInWebAdmin; Line 51: -- To view, visit http://gerrit.ovirt.org/14776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33cf80871e5c0567ccb47d307342fbcf36911d4c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
